PHPC-229: Support options array as 2nd argument to Manager ctor #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjori
force-pushed
the
PHPC-229-manager-options
branch
from
f3b9388 to
12d5b32
Compare
bjori
force-pushed
the
PHPC-229-manager-options
branch
from
12d5b32 to
49a2cc9
Compare
| bson_iter_recurse(&iter, &sub); | ||
| while (bson_iter_next (&sub)) { | ||
| if (BSON_ITER_HOLDS_UTF8(&sub)) { | ||
| mongoc_uri_parse_host(uri, bson_iter_utf8(&sub, NULL)); |
There was a problem hiding this comment.
Compiler warning:
./php_phongo.c: In function ‘php_phongo_make_uri’:
./php_phongo.c:1526:7: warning: implicit declaration of function ‘mongoc_uri_parse_host’ [-Wimplicit-function-declaration]
mongoc_uri_parse_host(uri, bson_iter_utf8(&sub, NULL));
I opened mongodb/mongo-c-driver#250
There was a problem hiding this comment.
jmikola
added a commit
that referenced
this pull request
Jul 22, 2015
|
Manually merged in: a1ebdcc We can bump the libmongoc submodule once https://mongodbcr.appspot.com/15020002/ is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-229