Skip to content

Fix memory leak and change warnings to exceptions in bson_to_zval() #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 30, 2015
Merged

Fix memory leak and change warnings to exceptions in bson_to_zval() #68

merged 4 commits into from
Jul 30, 2015

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented Jul 29, 2015

@jmikola
bson_to_zval() should always initialize state->zchild
4aec536 
This avoids a possible segfault in calling code, were it to zval_ptr_dtor() state->zchild before initialization (i.e. bson_to_zval() returns early on error).
@jmikola jmikola merged commit 4aec536 into mongodb:master Jul 30, 2015
jmikola added a commit that referenced this pull request Jul 30, 2015
@jmikola
Merge pull request #68
25a6cfc
@jmikola jmikola deleted the phpc-345 branch July 30, 2015 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jmikola