Test fixes for libmongoc 1.9.0-dev (post rc1) #701
Conversation
| @@ -28,10 +28,10 @@ echo throws(function() use ($bulk) { | |||
| <?php exit(0); ?> | |||
| --EXPECT-- | |||
| OK: Got MongoDB\Driver\Exception\InvalidArgumentException | |||
| update document contains invalid key: empty key | |||
| invalid selector for update: empty key | |||
There was a problem hiding this comment.
Note: this expected output will need to be changed again once mongodb/mongo-c-driver#472 is merged.
There was a problem hiding this comment.
Do we care enough about the exact word? I'd be happy if we just just %s for the word "selector"/"argument".
There was a problem hiding this comment.
I personally don't care, but without this test we wouldn't have caught the mistake in libmongoc. I don't think libmongoc is going to add tests for all of its error messages, so I'm OK with keeping this around.
| @@ -0,0 +1,48 @@ | |||
| --TEST-- | |||
| MongoDB\Driver\Manager::executeCommand() options | |||
There was a problem hiding this comment.
This file was renamed from manager-executeRawCommand-001.phpt
There was a problem hiding this comment.
I had specifically named this to match that PR's changes - where we have Raw, Read, Write, and ReadWrite, so I am not sure if this a good idea.
There was a problem hiding this comment.
Was this the only occurrence of "Raw" from that PR? I gathered it was more confusing to have a test named in the class-method for a method that doesn't exist.
We both know that executeCommand() implies MONGO_CMD_RAW. Would adding "Raw Command" (or similar) to the test title be a fair compromise?
There was a problem hiding this comment.
Just noticed that manager-executeCommand_error-002.phpt was added in the same PR and didn't use the "RawCommand" name.
| <?php exit(0); ?> | ||
| --EXPECTF-- | ||
| Read Preference: secondary | ||
| Read Concern: local |
There was a problem hiding this comment.
Note: this test currently fails because CDRIVER-2418 now ignores the readConcern option unless the read flag is set for the command (not done for the raw and write modes). This should be fixed by CDRIVER-2422.
| public function commandFailed( \MongoDB\Driver\Monitoring\CommandFailedEvent $event ) | ||
| { | ||
| } | ||
| public function commandStarted( \MongoDB\Driver\Monitoring\CommandStartedEvent $event ) |
There was a problem hiding this comment.
I noticed that some of the newer executeCommand() tests were using tabs instead of spaces. A text search turned up many more occurrences, so I've fixed them all in a single commit within this PR.
There was a problem hiding this comment.
I think this is a pointless change. And would rather have seen that in a specific PR, as now it's more difficult to review this as I have to go through all of it.
| public function commandFailed( \MongoDB\Driver\Monitoring\CommandFailedEvent $event ) | ||
| { | ||
| } | ||
| public function commandStarted( \MongoDB\Driver\Monitoring\CommandStartedEvent $event ) |
There was a problem hiding this comment.
I think this is a pointless change. And would rather have seen that in a specific PR, as now it's more difficult to review this as I have to go through all of it.
| @@ -28,10 +28,10 @@ echo throws(function() use ($bulk) { | |||
| <?php exit(0); ?> | |||
| --EXPECT-- | |||
| OK: Got MongoDB\Driver\Exception\InvalidArgumentException | |||
| update document contains invalid key: empty key | |||
| invalid selector for update: empty key | |||
There was a problem hiding this comment.
Do we care enough about the exact word? I'd be happy if we just just %s for the word "selector"/"argument".
| @@ -0,0 +1,48 @@ | |||
| --TEST-- | |||
| MongoDB\Driver\Manager::executeCommand() options | |||
There was a problem hiding this comment.
I had specifically named this to match that PR's changes - where we have Raw, Read, Write, and ReadWrite, so I am not sure if this a good idea.
jmikola
force-pushed
the
libmongoc-1.9-test-fixes
branch
2 times, most recently
from
8c08b5f to
15771c4
Compare
jmikola
force-pushed
the
libmongoc-1.9-test-fixes
branch
2 times, most recently
from
6109d13 to
464265e
Compare
The error message was changed in mongodb/mongo-c-driver@a625b39
The error message was changed in mongodb/mongo-c-driver@0c9cc9d
As of mongodb/mongo-c-driver@c2639c8, libmongoc no longer adds a default write concern to commands.
This serves as a reminder that executeCommand() is the execution method for raw commands.
This test is adapted from manager-executeCommand-004.phpt.
jmikola
force-pushed
the
libmongoc-1.9-test-fixes
branch
from
464265e to
154ca93
Compare
https://jira.mongodb.org/browse/PHPC-1037