Skip to content

PHPC-1072: mongoc_client_command_with_opts() reply must always be freed #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2017

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented Dec 15, 2017

https://jira.mongodb.org/browse/PHPC-1072

Previously, reply might leak if phongo_execute_command() returned due to an error (result=false).

@jmikola jmikola requested a review from derickr December 15, 2017 06:22
Copy link
Contributor

@derickr derickr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But please don't add random formatting changes to functional pull requests :-)

No mixing!

Previously, reply might leak if phongo_execute_command() returned due to an error (result=false).
@jmikola
Copy link
Member Author

jmikola commented Dec 15, 2017

But please don't add random formatting changes to functional pull requests :-)

I removed the changes to manager-executeCommand-004.phpt and server-executeCommand-006.phpt.

@jmikola jmikola merged commit 4924d8b into mongodb:master Dec 15, 2017
jmikola added a commit that referenced this pull request Dec 15, 2017
@jmikola jmikola deleted the phpc-1072 branch December 15, 2017 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants