PHPC-1144: Use server-side error code for BulkWriteException #785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
reviewed
Mar 22, 2018
php_phongo.c
Outdated
| @@ -671,7 +671,7 @@ bool phongo_execute_bulk_write(mongoc_client_t* client, const char* namespace, p | |||
| if (!success) { | |||
| if ((error.domain == MONGOC_ERROR_COMMAND && error.code != MONGOC_ERROR_COMMAND_INVALID_ARG) || | |||
| error.domain == MONGOC_ERROR_SERVER || error.domain == MONGOC_ERROR_WRITE_CONCERN) { | |||
| phongo_throw_exception(PHONGO_ERROR_WRITE_FAILED TSRMLS_CC, "%s", error.message); | |||
| zend_throw_exception(php_phongo_bulkwriteexception_ce, error.message, error.code TSRMLS_CC); | |||
There was a problem hiding this comment.
Independent of this, I think (error.domain == MONGOC_ERROR_COMMAND && error.code != MONGOC_ERROR_COMMAND_INVALID_ARG) in the above condition is probably redundant now that we're using libmongoc error API v2. I think I missed this in 1ad6d75#diff-c06c6e1c9374aecabcf544157f9d0c26L705.
If we leave that in place, I suppose there's a small chance we might use a BulkWriteException for a MONGOC_ERROR_PROTOCOL_BAD_WIRE_VERSION code under the MONGOC_ERROR_COMMAND domain.
Could you address it in a second commit associated with PHPC-1090?
jmikola
approved these changes
Mar 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-1144