-
Notifications
You must be signed in to change notification settings - Fork 208
PHPC-1113: Migrate tests to use a common URI env var #787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
f4cf0fe
8a83606
cf6aa41
6960868
fe52b48
38405a7
3a1362b
8768f54
55e3341
b4062f8
fc4cbd4
5f7f350
037e393
9d4bc8d
f242f9d
0534486
e50a011
9f7d2af
0f15a16
58fa85e
2cbe426
73fc8a5
014f2b6
7ddb1fd
25f9c3d
aee1d13
27a0452
6cafb28
f79a626
fc8b862
f7d8169
62797b0
8ca94d0
dcc2fdf
e70c79d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
@@ -1,12 +1,14 @@ | ||||
--TEST-- | ||||
MongoDB\Driver\Monitoring\addSubscriber(): Adding one subscriber | ||||
--SKIPIF-- | ||||
<?php require __DIR__ . "/../utils/basic-skipif.inc"; CLEANUP(STANDALONE) ?> | ||||
<?php require __DIR__ . "/../utils/basic-skipif.inc"; ?> | ||||
<?php skip_if_not_live(); ?> | ||||
<?php skip_if_not_clean(); ?> | ||||
--FILE-- | ||||
<?php | ||||
require_once __DIR__ . "/../utils/basic.inc"; | ||||
|
||||
$m = new MongoDB\Driver\Manager(STANDALONE); | ||||
$m = new MongoDB\Driver\Manager(URI); | ||||
|
||||
class MySubscriber implements MongoDB\Driver\Monitoring\CommandSubscriber | ||||
{ | ||||
|
@@ -24,7 +26,6 @@ class MySubscriber implements MongoDB\Driver\Monitoring\CommandSubscriber | |||
} | ||||
} | ||||
|
||||
CLEANUP( STANDALONE ); | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does this not mean we're not cleaning up data? Maybe I misunderstand. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These instances of
|
||||
$query = new MongoDB\Driver\Query( [] ); | ||||
$subscriber = new MySubscriber; | ||||
|
||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You did write a script for this one, right? :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a scripted search and replace, but everything else was manual as it required adding c conditional skips (e.g.
REPLICASET
needed to require a replica set topology). After bulk-changing these toURI
, I then ran the suite against various topologies to determine which tests were not topology-agnostic.