PHPC-1156: Prefer Secure Transport over OpenSSL with --with-mongodb-ssl on Darwin #795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should just require running |
|
I think this works! Before the change, my Mac shows After the change, it shows |
jmikola
approved these changes
Apr 10, 2018
vntw
approved these changes
Apr 11, 2018
derickr
force-pushed
the
PHPC-1156-darwin-secure-transport
branch
from
7511100 to
cb81027
Compare
derickr
added a commit
that referenced
this pull request
Apr 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-1156
@kvwalker — as I don't have a Mac, could you test this patch by running
./configure --with-mongodb-ssland see if it picks Secure Transport please? Before the patch it should (try to) pick OpenSSL.