PHPC-1159: Test on specific server versions in Travis CI #804
Conversation
| global: | ||
| - TEST_PHP_ARGS="-q -s output.txt -g XFAIL,FAIL,BORK,WARN,LEAK,SKIP -x --show-diff" | ||
| - REPORT_EXIT_STATUS=1 | ||
| - php: 7.0 |
There was a problem hiding this comment.
What's the reason for doing this with PHP 7.0, and not 7.2 for example?
There was a problem hiding this comment.
No reason in particular. The test for PHPLIB just happened to use PHP 7.0 to test older server versions.
|
|
||
| before_install: | ||
| - pip install "mongo-orchestration>=0.6.7,<1.0" --user `whoami` |
There was a problem hiding this comment.
This produced a warning in the Travis run: https://travis-ci.org/mongodb/mongo-php-driver/jobs/366254607#L553 — is that going to be a problem in the near future?
There was a problem hiding this comment.
I expect this is due to older version of Python on the Travis images. Perhaps @ShaneHarvey can chime in here.
There was a problem hiding this comment.
Per @behackett, we don't need to worry about this warning. A legitimate concern would be if the version of OpenSSL on these old CI environments causes connectivity issues due to not supporting TLS v1.2, but that's a completely different class of error.
| global: | ||
| - TEST_PHP_ARGS="-q -s output.txt -g XFAIL,FAIL,BORK,WARN,LEAK,SKIP -x --show-diff" | ||
| - REPORT_EXIT_STATUS=1 | ||
| - php: 7.0 |
There was a problem hiding this comment.
No reason in particular. The test for PHPLIB just happened to use PHP 7.0 to test older server versions.
|
|
||
| before_install: | ||
| - pip install "mongo-orchestration>=0.6.7,<1.0" --user `whoami` |
There was a problem hiding this comment.
I expect this is due to older version of Python on the Travis images. Perhaps @ShaneHarvey can chime in here.
| @@ -34,12 +34,12 @@ $startTime = microtime(true); | |||
| echo "Awaiting results...\n"; | |||
| $it->next(); | |||
| printf("Waited for %.6f seconds\n", microtime(true) - $startTime); | |||
|
|
|||
| // Sometimes the cursor will wait for 0.09999 seconds and sometimes it will wait for 0.1000. | |||
There was a problem hiding this comment.
Did you mean 0.0099 and 0.01, which is 9.9ms and 10ms respectively? As-is, this comment doesn't agree with the pattern below, as you're always expecting 0.0 and that would conflict with a possible 0.1000.
There was a problem hiding this comment.
Yes, that's definitely what I meant, thanks!
|
This may need another rebase due to recent changes in Beyond that, I'm LGTM but we can wait until @derickr acknowledges the comments above. |
…ime _id values in the same collection
https://jira.mongodb.org/browse/PHPC-1159