[1.4] Invalid namespace test needs STANDALONE #806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
changed the title
In b29c423 for PHPC-1057, Manager's execute methods were changed to perform server selection before invoking the phongo_execute functions, which throw InvalidArgumentExceptions such as this. Without a running standalone server, this test will encounter a server selection failure before we have a chance to parse the namespace string.
jmikola
force-pushed
the
1.4-invalidnamespace
branch
from
e404505 to
1904f7e
Compare
kvwalker
approved these changes
Apr 16, 2018
jmikola
added a commit
that referenced
this pull request
Apr 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In b29c423 for PHPC-1057, Manager's execute methods were changed to perform server selection before invoking the phongo_execute functions, which throw InvalidArgumentExceptions such as this. Without a running standalone server, this test will encounter a server selection failure before we have a chance to parse the namespace string.
Coincidentally, this wasn't a problem for #797 and PHPC-1148 because the BulkWrite tests already depended on a server.
This may require additional changes to overcome 0b200dd#diff-55a0adcc57688dbb2268c375b99e3403 when merging to master. If so, I will include those changes in a separate commit.