Do not re-execute BulkWrite in WriteResult::getServer() test #808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvwalker
approved these changes
Apr 16, 2018
bulkwrite_error-002.phpt already covers this case.
jmikola
force-pushed
the
1.4-writeresult-getserver
branch
from
6321d3c to
042c56b
Compare
jmikola
added a commit
that referenced
this pull request
Apr 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bulkwrite_error-002.phpt already covers this case.
Furthermore, this was never the correct exception class. The class in 1.4 and previous versions is is BulkWriteException, which just so happens to be an instance of RuntimeException and satisfy
throws(); however, #797 changes the class to InvalidArgumentException in 1.5.