PHPC-578: phongo_execute_command() should still throw ExecutionTimeoutException #809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That test does fail for me locally with |
kvwalker
approved these changes
Apr 16, 2018
…tException This fixes an inadvertent side effect of 4b70d9b.
jmikola
force-pushed
the
phpc-578-exceededtimelimit
branch
from
335710a to
c154b49
Compare
jmikola
added a commit
that referenced
this pull request
Apr 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-578
This fixes an inadvertent side effect of 4b70d9b, which caused test failures for standalone/executiontimeoutexception-002.phpt.
@kvwalker: Before you review this, please see if that test fails or is skipped on your local environment. I imagine it might have been skipped for some reason (it certainly is on Travis, as the MongoDB servers there don't start with test command enabled).