PHPC-314: Added a few tests that don't touch the server #812
Conversation
tests/bson/bson-toPHP-008.phpt
Outdated
| --FILE-- | ||
| <?php | ||
|
|
||
| require_once __DIR__ . "/../utils/basic.inc"; |
There was a problem hiding this comment.
basic.inc requires PHONGO-SERVERS.json. You should be use require_once __DIR__ . '/../utils/tools.php'; for a non-server test.
Note: this wasn't a problem in bson-toPHP-007.phpt from your earlier PR, as you didn't include anything there. That said, I don't think anything in this test actually needs a helper function in tools.php, since you're calling the BSON functions by their full namespace.
There was a problem hiding this comment.
Yeah, it seems I missed to change these lines.
tests/bson/bson-toPHP-008.phpt
Outdated
| ] ); | ||
|
|
||
| function fetch($bson, $typeMap = []) { | ||
| return [ \MongoDB\BSON\toPHP($bson, $typeMap) ]; |
There was a problem hiding this comment.
Is there any reason for this to return an array if all of the tests have to access the first element before asserting?
There was a problem hiding this comment.
I had left it so that the assertions were the same as the tests where these were copied from. I'll change them.
|
Travis failures are likely due to #813. Please rebase. |
derickr
force-pushed
the
PHPC-314-extra-tests
branch
from
3f30d7e to
af325a2
Compare
tests/bson/bson-toPHP-008.phpt
Outdated
| --FILE-- | ||
| <?php | ||
|
|
||
| require_once __DIR__ . "/../utils/basic.inc"; |
There was a problem hiding this comment.
Yeah, it seems I missed to change these lines.
tests/bson/bson-toPHP-008.phpt
Outdated
| ] ); | ||
|
|
||
| function fetch($bson, $typeMap = []) { | ||
| return [ \MongoDB\BSON\toPHP($bson, $typeMap) ]; |
There was a problem hiding this comment.
I had left it so that the assertions were the same as the tests where these were copied from. I'll change them.
derickr
force-pushed
the
PHPC-314-extra-tests
branch
from
af325a2 to
032f08f
Compare
No description provided.