PHPC-1163: Prohibit session with unacknowledged write concern #814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvwalker
approved these changes
Apr 19, 2018
php_phongo.c
Outdated
|
|
||
| /* Determine if the explicit or inherited write concern is | ||
| * unacknowledged so that we can ensure it does not conflict with an | ||
| * explicit of implicit session. */ |
There was a problem hiding this comment.
"explicit of implicit session" should be "explicit or implicit session"
jmikola
force-pushed
the
1.4-phpc-1163
branch
2 times, most recently
from
a77aa65 to
159d25e
Compare
jmikola
commented
Apr 20, 2018
| --TEST-- | ||
| PHPC-1163: Unacknowledged write concern should omit implicit session | ||
| --XFAIL-- | ||
| Depends on CDRIVER-2615 |
There was a problem hiding this comment.
Tests pass locally after applying the patch from CDRIVER-2615, but feel free to verify on your own. In any event, that fix won't show up until libmongoc 1.10.
derickr
approved these changes
Apr 24, 2018
tests/manager/bug1163-001.phpt
Outdated
| --XFAIL-- | ||
| Depends on CDRIVER-2615 | ||
| --SKIPIF-- | ||
| <?php if (PHP_INT_SIZE !== 8) { die("skip Can't represent 64-bit ints on a 32-bit platform"); } ?> |
There was a problem hiding this comment.
Extra space in front of <?php.
This adds checks to ensure that explicit sessions and unacknowledged write concerns (explicit or inherited) will not be mixed when executing bulk writes or commands. Additionally, we ensure that command execution does not create its own implicit session (per PHPC-1152) if the effective write concern is unacknowledged. Note: libmongoc still needs to ensure that it does not create implicit sessions for unacknowledged commands (CDRIVER-2615).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-1163
This adds checks to ensure that explicit sessions and unacknowledged write concerns (explicit or inherited) will not be mixed when executing bulk writes or commands. Additionally, we ensure that command execution does not create its own implicit session (per PHPC-1152) if the effective write concern is unacknowledged.
Note: libmongoc still needs to ensure that it does not create implicit sessions for unacknowledged commands (CDRIVER-2615).