Skip to content

PHPC-1166: Remove inline hint to fix linking issues on Windows #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions phongo_compat.c
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ void phongo_add_exception_prop(const char* prop, int prop_len, zval* value TSRML
}

#ifdef ZEND_HASH_GET_APPLY_COUNT /* PHP 7.2 or earlier recursion protection */
inline zend_bool php_phongo_zend_hash_apply_protection_begin(HashTable* ht)
zend_bool php_phongo_zend_hash_apply_protection_begin(HashTable* ht)
{
if (!ht) {
return 1;
Expand All @@ -47,7 +47,7 @@ inline zend_bool php_phongo_zend_hash_apply_protection_begin(HashTable* ht)
return 1;
}

inline zend_bool php_phongo_zend_hash_apply_protection_end(HashTable* ht)
zend_bool php_phongo_zend_hash_apply_protection_end(HashTable* ht)
{
if (!ht) {
return 1;
Expand All @@ -61,7 +61,7 @@ inline zend_bool php_phongo_zend_hash_apply_protection_end(HashTable* ht)
return 1;
}
#else /* PHP 7.3 or later */
inline zend_bool php_phongo_zend_hash_apply_protection_begin(zend_array* ht)
zend_bool php_phongo_zend_hash_apply_protection_begin(zend_array* ht)
{
if (GC_IS_RECURSIVE(ht)) {
return 0;
Expand All @@ -72,7 +72,7 @@ inline zend_bool php_phongo_zend_hash_apply_protection_begin(zend_array* ht)
return 1;
}

inline zend_bool php_phongo_zend_hash_apply_protection_end(zend_array* ht)
zend_bool php_phongo_zend_hash_apply_protection_end(zend_array* ht)
{
if (!GC_IS_RECURSIVE(ht)) {
return 0;
Expand Down