PHPC-1270: Upgrade libmongoc to 1.13.0 #926
Merged
+14
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
approved these changes
Sep 19, 2018
There was a problem hiding this comment.
Tested the following:
- Windows build with PHP 5.6 (x86) and PHP 7.1 (x64)
- Linux build using PHP 7.2 and libmongoc system libraries (all tests run on single-node RS)
- Linux build using PHP 5.5 and PHP 7.2 using libmongoc submodule (all tests run on single-node RS)
I did encounter one unexpected test failure, but that's unrelated to this PR. I addressed it in #927, so hopefully we can get that into v1.5 as well before the 1.5.3 release.
derickr
force-pushed
the
PHPC-1270-libmongoc-1.13
branch
2 times, most recently
from
0b58415 to
4e2fca4
Compare
derickr
force-pushed
the
PHPC-1270-libmongoc-1.13
branch
from
4e2fca4 to
26d2764
Compare
derickr
added a commit
that referenced
this pull request
Sep 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.