PHPC-1180: Fix STANDALONE_SSL build failures on Travis #962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The --user option does not solicit a value, so this was previously attempting to install a package sharing a name with the current user.
These were originally added in mongodb-labs/mongo-orchestration@4f71d29, but it's not clear what they were used for since server configs specify their own paths and Mongo Orchestration relies on MONGO_ORCHESTRATION_HOME.
This will allow Mongo Orchestration to connect to a server/cluster using SSL.
sslWeakCertificateValidation is more permissive, so this may be redundant. MO's own configurations don't specify this for SSL environments.
This option was introduced in 3.0 and supersedes sslWeakCertificateValidation.
Per my original comment in the ticket, this URI option could conflict with older SSL-specific tests that relied on peer verification using PEM files. We'll still need to investigate those tests later, but it turns out this option wasn't needed for other tests to connect to an SSL server as previously assumed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-1180