PHPC-1378: Omit CFLAGS/LDFLAGS in client metadata to avoid platform truncation #985
Conversation
| dnl We can do this after the above scripts as they only modify STD_CFLAGS | ||
| AS_VAR_COPY(MONGOC_USER_SET_CFLAGS, [CFLAGS]) | ||
| AS_VAR_COPY(MONGOC_USER_SET_LDFLAGS, [LDFLAGS]) | ||
| AS_VAR_COPY(MONGOC_CC, [CC]) |
There was a problem hiding this comment.
I don't recall why AS_VAR_COPY was used here, unless it had something to do with resolving variables within CFLAGS and LDFLAGS; however, I can't make the connection to the polymorphic variable example provided in the Autoconf manual.
In any event, I don't think it was necessary for $CC since that should simply be the compiler name.
| dnl consider restoring CFLAGS/LDFLAGS once CDRIVER-3134 is resolved. | ||
| AC_SUBST(MONGOC_CC, [$CC]) | ||
| AC_SUBST(MONGOC_USER_SET_CFLAGS, []) | ||
| AC_SUBST(MONGOC_USER_SET_LDFLAGS, []) |
There was a problem hiding this comment.
I manually verified that this produces the same output in configure as the original pairing of AS_VAR_COPY and AC_SUBST:
MONGOC_CC=$CC
Predictably, there is no assignment for CFLAGS/LDFLAGS in configure with the empty AC_SUBST macros; however, MONGOC_USER_SET_LDFLAGS and MONGOC_USER_SET_CFLAGS are still included in ac_subst_vars which ensures that they at least get replaced when processing mongoc-config.h.in. @MONGOC_USER_SET_LDFLAGS@ and @MONGOC_USER_SET_CFLAGS@ are both replaced with empty strings during configuration.
There was a problem hiding this comment.
That makes sense. Your change is certainly more straightforward in terms of what is happening.
| dnl consider restoring CFLAGS/LDFLAGS once CDRIVER-3134 is resolved. | ||
| AC_SUBST(MONGOC_CC, [$CC]) | ||
| AC_SUBST(MONGOC_USER_SET_CFLAGS, []) | ||
| AC_SUBST(MONGOC_USER_SET_LDFLAGS, []) |
There was a problem hiding this comment.
That makes sense. Your change is certainly more straightforward in terms of what is happening.
https://jira.mongodb.org/browse/PHPC-1378