Skip to content

Commit 0bf583c

Browse files
authored
Skip additional change stream "comment" tests (#914)
1 parent 20e8f91 commit 0bf583c

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

tests/UnifiedSpecTests/UnifiedSpecTest.php

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,6 @@ class UnifiedSpecTest extends FunctionalTestCase
2121
{
2222
/** @var array */
2323
private static $incompleteTests = [
24-
'change-streams/change-streams: Test with document comment' => 'Not yet implemented (PHPLIB-749)',
25-
'change-streams/change-streams: Test with string comment' => 'Not yet implemented (PHPLIB-749)',
26-
'change-streams/change-streams: Test that comment is set on getMore' => 'Not yet implemented (PHPLIB-749)',
27-
'command-monitoring/pre-42-server-connection-id: command events do not include server connection id' => 'Not yet implemented (PHPC-1899, PHPLIB-718)',
28-
'command-monitoring/server-connection-id: command events include server connection id' => 'Not yet implemented (PHPC-1899, PHPLIB-718)',
2924
// Many load balancer tests use CMAP events and/or assertNumberConnectionsCheckedOut
3025
'load-balancers/cursors are correctly pinned to connections for load-balanced clusters: no connection is pinned if all documents are returned in the initial batch' => 'PHPC does not implement CMAP',
3126
'load-balancers/cursors are correctly pinned to connections for load-balanced clusters: pinned connections are returned when the cursor is drained' => 'PHPC does not implement CMAP',
@@ -64,6 +59,15 @@ class UnifiedSpecTest extends FunctionalTestCase
6459
'valid-pass/entity-client-cmap-events: events are captured during an operation' => 'PHPC does not implement CMAP',
6560
'valid-pass/expectedEventsForClient-eventType: eventType can be set to command and cmap' => 'PHPC does not implement CMAP',
6661
'valid-pass/expectedEventsForClient-eventType: eventType defaults to command if unset' => 'PHPC does not implement CMAP',
62+
// Command monitoring event serverConnectionId is not yet implemented
63+
'command-monitoring/pre-42-server-connection-id: command events do not include server connection id' => 'Not yet implemented (PHPC-1899, PHPLIB-718)',
64+
'command-monitoring/server-connection-id: command events include server connection id' => 'Not yet implemented (PHPC-1899, PHPLIB-718)',
65+
// Change stream "comment" option is not yet implemented
66+
'change-streams/change-streams: Test with document comment' => 'Not yet implemented (PHPLIB-749)',
67+
'change-streams/change-streams: Test with document comment - pre 4.4' => 'Not yet implemented (PHPLIB-749)',
68+
'change-streams/change-streams: Test with string comment' => 'Not yet implemented (PHPLIB-749)',
69+
'change-streams/change-streams: Test that comment is set on getMore' => 'Not yet implemented (PHPLIB-749)',
70+
'change-streams/change-streams: Test that comment is not set on getMore - pre 4.4' => 'Not yet implemented (PHPLIB-749)',
6771
// CRUD "comment" option is not yet implemented
6872
'crud/bulkWrite-comment: BulkWrite with string comment' => 'Not yet implemented (PHPC-2049, PHPLIB-749)',
6973
'crud/bulkWrite-comment: BulkWrite with document comment' => 'Not yet implemented (PHPC-2049, PHPLIB-749)',

0 commit comments

Comments
 (0)