Skip additional change stream "comment" tests #914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
commented
Apr 15, 2022
| 'change-streams/change-streams: Test with document comment - pre 4.4' => 'Not yet implemented (PHPLIB-749)', | ||
| 'change-streams/change-streams: Test with string comment' => 'Not yet implemented (PHPLIB-749)', | ||
| 'change-streams/change-streams: Test that comment is set on getMore' => 'Not yet implemented (PHPLIB-749)', | ||
| 'change-streams/change-streams: Test that comment is not set on getMore - pre 4.4' => 'Not yet implemented (PHPLIB-749)', |
There was a problem hiding this comment.
The "pre 4.4" skips were missing, as I didn't catch those in the PR CI matrix.
| @@ -64,6 +59,15 @@ class UnifiedSpecTest extends FunctionalTestCase | |||
| 'valid-pass/entity-client-cmap-events: events are captured during an operation' => 'PHPC does not implement CMAP', | |||
| 'valid-pass/expectedEventsForClient-eventType: eventType can be set to command and cmap' => 'PHPC does not implement CMAP', | |||
| 'valid-pass/expectedEventsForClient-eventType: eventType defaults to command if unset' => 'PHPC does not implement CMAP', | |||
| // Command monitoring event serverConnectionId is not yet implemented | |||
There was a problem hiding this comment.
No functional change here. Just shuffling around the entries and adding a comment above this group.
aleksandr-rudo
approved these changes
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missed in #908 and introduced some avoidable test failures in the full matrix (see: task log).