PHPLIB-866: CSFLE prose test for on-demand AWS credentials #1009
Conversation
| TOPOLOGY: "replica_set" | ||
| - func: "start kms servers" | ||
| - func: "run tests" | ||
| vars: |
There was a problem hiding this comment.
I just improved my understanding of the vars construct by reading through Expansions in the Evergreen docs.
Notice that the function reference can define a set of vars which are treated as expansions within the configuration of the commands in the function.
I reckon my prior confusion was due to our historically inconsistent naming/formatting. I assumed some (like "TESTS") were environment variables, but that's not the case until we explicitly export or declare them when invoking a shell command.
A few more of these PRs and I'll probably want to take on some Evergreen config refactoring.
There was a problem hiding this comment.
A few more of these PRs and I'll probably want to take on some Evergreen config refactoring.
I'll make a note of it to remember when the next refactoring inevitably comes around...
| ]; | ||
|
|
||
| if (! $shouldSucceed) { | ||
| $this->expectException(AuthenticationException::class); |
There was a problem hiding this comment.
This is more specific than some other assertions we make in this file, but I inferred it from the corresponding libmongoc test in mongodb/mongo-c-driver@9c4f49f#diff-d363a5539f2fbabfadf2d7cc6cdb96a203fb63f2caa31bae731c3e12d97b204cR5013.
| * | ||
| * @see https://github.com/mongodb/specifications/tree/master/source/client-side-encryption/tests#on-demand-aws-credentials | ||
| * @testWith [true] | ||
| * [false] |
There was a problem hiding this comment.
The $shouldSucceed=false case corresponds to testOnDemandAwsCredentials_with_data_set__1 in this task log.
https://jira.mongodb.org/browse/PHPLIB-866
Patch build: https://spruce.mongodb.com/version/63857b60d6d80a169794c4e0/tasks