[BLOCKED] PHPLIB-1033 and PHPLIB-1042: Sync spec tests for retryable handshake errors #1011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync unified retryable reads/writes tests with mongodb/specifications@35b17b7 Includes spec tests for PHPLIB-1042 and some unified retryable writes tests that were missed in 40f231d for PHPLIB-755
|
After debugging some traces in libmongoc, I realized that the original CDRIVER PR for this (mongodb/mongo-c-driver#1141) excluded adding retry logic to the one API used by PHPC for executing operations. I created CDRIVER-4532 and have marked the PHPLIB tickets as blocked until that can be addressed. |
jmikola
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPLIB-1033
https://jira.mongodb.org/browse/PHPLIB-1042
Also adds a replica set w/ auth to the Evergreen matrix, which is needed to run some of the synced tests.
Patch build: https://spruce.mongodb.com/version/6389522157e85a1fff7d0c01/tasks