PHPLIB-909: Add more error response tests #1012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
approved these changes
Dec 6, 2022
| } elseif ($e instanceof WriteException) { | ||
| $writeErrors = $e->getWriteResult()->getErrorReplies(); | ||
| assertCount(1, $writeErrors); | ||
| assertThat($writeErrors[0], $this->matchesResultDocument, 'WriteException result document matches'); |
There was a problem hiding this comment.
This isn't addressed in the spec (see: expectedError) but this is the correct approach. I intentionally only issued to single commands in the corresponding write command tests for this reason.
I was just reminded of this PR. This assumption is consistent with what was done in libmongoc. See: mongodb/mongo-c-driver#1144 (comment) and my comment in DRIVERS-1547. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to PHPLIB-909 that removes the 4 previously skipped tests now that
WriteResultexposes the errors as sent from the server. Since there may be multiple replies, I decided to only check the first one - another option would be to pass the test if any error response matches, but I'm not sure if that's feasible.