Skip unrelated builds for documentation #1043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
commented
Jan 18, 2023
Comment on lines
+9
to
+10
| paths-ignore: | ||
| - "docs/**" |
There was a problem hiding this comment.
I decided to only skip builds if we're only changing documentation: there are too many variables that affect the "should this require a test run" to be feasible (e.g. changes in orchestration, tests, config files, sources, tests, etc.). Listing all the directories in paths doesn't seem sensible, and skipping builds for pull requests/commits that ONLY change documentation should be sufficient for the time being.
jmikola
pushed a commit
to jmikola/mongo-php-library
that referenced
this pull request
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, GitHub Actions will no longer run the
coding-standards,static-analysis, andtestsworkflows when only documentation was changed. At the same time, thedocsworkflow is only run if files in the docs folder were changed.I'll caution that this may cause issues with branch protection: since we require the
testsworkflow to be stable in order for a PR to be mergeable, this may prove to be unfeasible due to us having to override branch protection rules for such pull requests.