Skip to content

PHPLIB-1093: Assert $expectedType array is non-empty for InvalidArgumentException #1049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 22, 2023

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented Mar 20, 2023

https://jira.mongodb.org/browse/PHPLIB-1093

This also factors out the logic for converting an $expectedType array to a string.

@jmikola jmikola requested a review from alcaeus March 20, 2023 15:37
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some suggestions to silence psalm. Running phpcbf will also fix the wrong use statement order.

Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmikola
Copy link
Member Author

jmikola commented Mar 22, 2023

Note: the Evergreen CI failures should be addressed by #1051.

@jmikola jmikola merged commit 2dd2e84 into mongodb:master Mar 22, 2023
@jmikola jmikola deleted the phplib-1093 branch March 22, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants