Skip to content

Extract DropEncryptedCollection operation from helper methods #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 12, 2023

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented Apr 3, 2023

This is based on the extraction of CreateEncryptedCollection for PHPLIB-913 in #1050.

This is based on the extraction of CreateEncryptedCollection for PHPLIB-913.
@jmikola jmikola requested a review from alcaeus April 3, 2023 07:01
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feel free to apply or ignore suggested patches at your discretion.

@jmikola
Copy link
Member Author

jmikola commented Apr 12, 2023

Coding standard CI failure is due to PHPLIB-1106 and will be addressed by #1058.

The CI build failures for mongodb-latest are due to PHPLIB-1088 and will be addressed in a subsequent PR.

@jmikola jmikola merged commit 55c62d3 into mongodb:master Apr 12, 2023
@jmikola jmikola deleted the dropencryptedcollection-operation branch April 12, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants