Skip to content

PHPLIB-1132: Sync unified spec tests for revised runOnRequirements #1065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 13, 2023

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented Apr 20, 2023

https://jira.mongodb.org/browse/PHPLIB-1132

POC for mongodb/specifications#1408 (DRIVERS-2609).

This also adds unified tests for retryable writes that were originally missed in PHPLIB-755.

Patch build: https://spruce.mongodb.com/version/64422c46850e615956fc1a71/tasks

@jmikola jmikola changed the title POC for DRIVERS-2609 PHPLIB-1132: Sync unified spec tests for revised runOnRequirements May 12, 2023
@jmikola jmikola marked this pull request as ready for review May 12, 2023 02:30
@jmikola jmikola requested a review from alcaeus May 12, 2023 02:31
@jmikola jmikola force-pushed the poc-drivers-2609 branch from 47422c0 to e52d3a8 Compare May 12, 2023 02:45
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM. Not sure why some of the checks don't even run, but since there's a conflict a force push might just resolve that.

@jmikola jmikola merged commit 5a4ee68 into mongodb:master May 13, 2023
@jmikola jmikola deleted the poc-drivers-2609 branch May 13, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants