PHPLIB-1135: Remove var_dump from tests, use print_r instead #1081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
var_dump output is modified by xdebug, leading to test failure during debug
jmikola
approved these changes
May 26, 2023
examples/persistable.php
Outdated
| @@ -106,4 +106,4 @@ public function bsonUnserialize(array $data): void | |||
| $foundEntry = $collection->findOne([]); | |||
|
|
|||
| /** @psalm-suppress ForbiddenCode */ | |||
There was a problem hiding this comment.
ForbiddenCode suppressions can be removed as only var_dump and shell_exec are included by default: https://psalm.dev/docs/running_psalm/configuration/#forbiddenfunctions
I tested this locally and confirmed.
There was a problem hiding this comment.
Done. This further impacts my lines added < lines deleted ratio. 😂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
var_dumpoutput is modified by xdebug, what causes tests to fail during debug.I think it's easier to read this way.
There other calls to
var_dumpinDocumentationExamplesTest, but they are hidden and not tested.