PHPLIB-1071: Do not create ECC collection and check wire version for QEv2 #1084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
approved these changes
May 30, 2023
The original logic in the Transactions legacy test runner only handled assertions for top-level fields. This adds logic to check fields within embedded documents, as needed by the CSFLE tests.
jmikola
commented
May 31, 2023
| continue; | ||
| } | ||
|
|
||
| if ($value instanceof stdClass && property_exists($actual, $key) && $actual->{$key} instanceof stdClass) { |
There was a problem hiding this comment.
Note: the previous code for this function was:
if ($value instanceof stdClass) {
static::assertObjectHasAttribute($key, $actual);
static::assertInstanceOf(stdClass::class, $actual->{$key});
static::assertCommandOmittedFields($value, $actual->{$key});
}This caused multiple test failures in the getMore.json test, which asserts that the getMore field of the outgoing command matches { "$$type": "long" }. The actual value in that case is an integer, which was problematic for assertInstanceOf() above.
Rather than rewrite assertCommandOmittedFields() to skip special operations (i.e. keys starting with "$$"), which is only defined in the CSFLE legacy test format, I opted to just NOP and avoid recursion. This keeps assertCommandOmittedFields() focused on it's original purpose of only asserting omitted fields and allows the caller to handle everything else (likely via assertDocumentsMatch()).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPLIB-1071