Skip to content

Remove phpcs:ignore comments for unused use statements #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2023

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented May 30, 2023

The line in DropEncryptedCollection was never necessary. The line in CreateEncryptedCollection may have been used at one point since Binary is only referenced in a psalm-var annotation, but phpcs no longer complains.

@jmikola jmikola requested a review from GromNaN May 30, 2023 11:36
@jmikola
Copy link
Member Author

jmikola commented May 30, 2023

Reported the unrelated test failure on MongoDB 4.0 shard cluster in PHPLIB-1151.

Other test failures are covered by PHPLIB-1115 and PHPLIB-1071.

The line in DropEncryptedCollection was never necessary. The line in CreateEncryptedCollection may have been used at one point since Binary is only referenced in a psalm-var annotation, but phpcs no longer complains.
@jmikola jmikola merged commit 7f0b902 into mongodb:master May 30, 2023
@jmikola jmikola deleted the use-statements branch May 30, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants