PHPLIB-1161: Leverage array_key_first in functions #1101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
commented
Jun 12, 2023
| @@ -319,11 +317,9 @@ function is_last_pipeline_operator_write(array $pipeline): bool | |||
| return false; | |||
| } | |||
|
|
|||
| $lastOp = document_to_array($lastOp); | |||
| $key = array_key_first(document_to_array($lastOp)); | |||
There was a problem hiding this comment.
I had a doubt whether it's array_key_first or array_key_last. But reset moves the cursor to the first element.
A new test case may be necessary as it doesn't fail when I change to get the first or the last key.
There was a problem hiding this comment.
I think the $lastOp array must contain exactly 1 item. That's why it doesn't matter. We could even have used key() directly without reset().
There was a problem hiding this comment.
I think the
$lastOparray must contain exactly 1 item.
That's correct - we're assuming this is an aggregation pipeline stage which only contains one key.
alcaeus
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PHPLIB-1161
The polyfill is already installed.