Skip to content

PHPLIB-1142: Use disableMD5 when provided to GridFS Bucket constructor #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 14, 2023

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Jun 14, 2023

Fix PHPLIB-1142

Bugfix, the option value set to the constructor was ignored. The only way to disable md5 was to set the option when calling Bucket::uploadFromStream.

Added a functional test to ensure this option works. But it does not cover this specific bug.

@GromNaN GromNaN requested review from jmikola and alcaeus June 14, 2023 10:37
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GromNaN GromNaN merged commit 4fd79ac into mongodb:master Jun 14, 2023
@GromNaN GromNaN deleted the PHPLIB-1142 branch June 14, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants