Skip to content

Add server description to the benchmark report #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 15, 2023

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Sep 15, 2023

This is to highlight that server topology have a huge impact on performance. #1161 (comment)

Example

image

@GromNaN GromNaN requested a review from alcaeus September 15, 2023 11:35
@GromNaN GromNaN changed the title Add server description to the report Add server description to the benchmark report Sep 15, 2023
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a tiny typo, LGTM otherwise. Good find about the environment provider, I think that's good information to print about the runs 👍


private static function createCollection(): Collection
{
return self::getClient()->selectCollection(self::getDatabase(), 'perftest');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any need to parameterize the collection name? I assume not now, and if this comes up down the line we can always switch over to a param with a default value.

Copy link
Member Author

@GromNaN GromNaN Sep 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seen you comment after merging. We will figure out if we need more than one collection.
Same for client options that were not used and that I removed in the PR.

@GromNaN GromNaN merged commit fdd7793 into mongodb:master Sep 15, 2023
@GromNaN GromNaN deleted the phpbench-env branch September 15, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants