-
Notifications
You must be signed in to change notification settings - Fork 266
Add server description to the benchmark report #1163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a tiny typo, LGTM otherwise. Good find about the environment provider, I think that's good information to print about the runs 👍
Co-authored-by: Andreas Braun <[email protected]>
|
||
private static function createCollection(): Collection | ||
{ | ||
return self::getClient()->selectCollection(self::getDatabase(), 'perftest'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any need to parameterize the collection name? I assume not now, and if this comes up down the line we can always switch over to a param with a default value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seen you comment after merging. We will figure out if we need more than one collection.
Same for client options that were not used and that I removed in the PR.
This is to highlight that server topology have a huge impact on performance. #1161 (comment)
Example