PHPLIB-1194: Test log message for non-genuine hosts #1173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
commented
Sep 25, 2023
| use function MongoDB\removeLogger; | ||
|
|
||
| /** @see https://jira.mongodb.org/browse/DRIVERS-2583 */ | ||
| class LogNonGenuineHostTest extends TestCase |
There was a problem hiding this comment.
This is the only relevant class in the PR. Everything else is from #1158.
jmikola
commented
Sep 25, 2023
| ['mongodb://a.MONGO.COSMOS.AZURE.COM:19555/'], | ||
| ['mongodb+srv://a.mongo.cosmos.azure.com/'], | ||
| ['mongodb+srv://A.MONGO.COSMOS.AZURE.COM/'], | ||
| // Mixing genuine and nongenuine hosts (unlikely in practice) |
There was a problem hiding this comment.
Note: not using named data providers was intentional, since it would have involved a lot of redundancy. I only added comments to notable test cases from my original libmongoc tests.
alcaeus
approved these changes
Sep 25, 2023
GromNaN
approved these changes
Sep 25, 2023
GromNaN
approved these changes
Sep 25, 2023
No. These aren't integration tests, as the logic for emitting these log messages is entirely client-side. |
jmikola
force-pushed
the
phplib-1194
branch
2 times, most recently
from
ead89cd to
2208186
Compare
jmikola
force-pushed
the
phplib-1194
branch
from
2208186 to
ed901e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPLIB-1194
Depends on #1158