Skip to content

PHPLIB-1303: Test with serverless proxy #1201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 29, 2024
Merged

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Nov 27, 2023

PHPLIB-1303

Serverless proxy tests currently fail with a lot of retry ability errors, which I'm still investigating.

@alcaeus alcaeus self-assigned this Nov 27, 2023
@alcaeus alcaeus changed the title PHPLIB-1303: Test with server less proxy PHPLIB-1303: Test with serverless proxy Nov 27, 2023
@alcaeus alcaeus changed the base branch from master to v1.17 November 29, 2023 09:00
@alcaeus
Copy link
Member Author

alcaeus commented Nov 29, 2023

Rebased to target v1.17 as the current serverless tests are already failing there, which this PR fixes. Note that the failing tests are more likely unrelated to our logic as they appear in multiple drivers.

@alcaeus alcaeus marked this pull request as ready for review November 29, 2023 09:01
@alcaeus alcaeus requested review from GromNaN and jmikola November 29, 2023 09:01
@jmikola
Copy link
Member

jmikola commented Jan 25, 2024

I noted the Psalm errors are related to #1218, which was only merged to master. Do you want to clamp the version requirement in composer.json to 5.19 to suppress this, or is it not worth caring about? Backporting #1218 would also address this, of course, but it's a slippery slope.

@alcaeus
Copy link
Member Author

alcaeus commented Jan 29, 2024

Updated to the last version. Note that a patch build including serverless shows failures for the serverless-proxy tests, which I've confirmed to be issues with the proxy itself.

@alcaeus alcaeus merged commit 02b6d3a into mongodb:v1.17 Jan 29, 2024
@alcaeus alcaeus deleted the phplib-1303 branch January 29, 2024 09:57
alcaeus added a commit that referenced this pull request Jan 29, 2024
* v1.17:
  PHPLIB-1303: Test with serverless proxy (#1201)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants