Skip to content

DOCSP-36027: Shorten class headings backport (#1229) #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2024
Merged

DOCSP-36027: Shorten class headings backport (#1229) #1236

merged 1 commit into from
Feb 27, 2024

Conversation

norareidy
Copy link
Contributor

@norareidy norareidy commented Feb 23, 2024 •
edited
Loading

Also consolidates result classes to a single section

(cherry picked from commit 00d44d4)

JIRA - https://jira.mongodb.org/browse/DOCSP-36027
Staging - https://preview-mongodbnorareidy.gatsbyjs.io/php-library/DOCSP-36027-backport/

@norareidy
DOCSP-36027: Shorten class headings in nav (mongodb#1229)
a84eb33 
Also consolidates result classes to a single section

(cherry picked from commit 00d44d4)
@norareidy norareidy marked this pull request as ready for review February 23, 2024 22:00
@jmikola
Copy link
Member

jmikola commented Feb 26, 2024 •
edited
Loading

All of the following pages have scrolling issues where the page is left below the start of content:

This may not be an exhaustive list, but it's what I collected from poking through the preview URL.

This came up previously in #1229 (comment) but there doesn't appear to be any conclusive solution there (I think you just worked around it). Let me know if you're OK merging this as-is or if there's something you want to adjust.

@norareidy
Copy link
Contributor Author

All of the following pages have scrolling issues where the page is left below the start of content:

This may not be an exhaustive list, but it's what I collected from poking through the preview URL.

This came up previously in #1229 (comment) but there doesn't appear to be any conclusive solution there (I think you just worked around it). Let me know if you're OK merging this as-is or if there's something you want to adjust.

I'm not seeing the same problem, although I brought it up to my team and one person was able to reproduce it. I also sent a message to DOP - here's the Slack thread if you want to take a look.

jmikola
jmikola approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@jmikola jmikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to leave as-is.

@jmikola jmikola merged commit 55b821b into mongodb:v1.16 Feb 27, 2024
@jmikola
Copy link
Member

jmikola commented Feb 27, 2024

Merged up to v1.17 in f454abd. This required adding back some content from 00d44d4 for methods introduced in 1.17+, which you correctly removed from the backport commit in this PR.

I then merged up v1.17 to master in 890ad37, which was mostly a no-op but added some missing newlines at the end of two files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmikola jmikola jmikola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@norareidy @jmikola