Skip to content

Exclude read-write-concern tests from serverless testing #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Exclude read-write-concern tests from serverless testing #1253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 46 additions & 12 deletions tests/UnifiedSpecTests/UnifiedSpecTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
* Unified test format spec tests.
*
* @see https://github.com/mongodb/specifications/blob/master/source/unified-test-format/unified-test-format.rst
* @group serverless
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was considering doing this while porting tests over the past few weeks. Looks like a good change.

I did overlook the conflict with the $out tests and serverless. I do think it'd be reasonable to go back and add serverless: forbid to that spec test's runOnRequirements.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened mongodb/specifications#1550 and #1254 to modify the spec tests.

*/
class UnifiedSpecTest extends FunctionalTestCase
{
Expand Down Expand Up @@ -231,7 +230,10 @@ public function provideAtlasDataLakeTests()
return $this->provideTests(__DIR__ . '/atlas-data-lake/*.json');
}

/** @dataProvider provideChangeStreamsTests */
/**
* @dataProvider provideChangeStreamsTests
* @group serverless
*/
public function testChangeStreams(UnifiedTestCase $test): void
{
self::$runner->run($test);
Expand All @@ -245,6 +247,7 @@ public function provideChangeStreamsTests()
/**
* @dataProvider provideClientSideEncryptionTests
* @group csfle
* @group serverless
*/
public function testClientSideEncryption(UnifiedTestCase $test): void
{
Expand All @@ -256,7 +259,10 @@ public function provideClientSideEncryptionTests()
return $this->provideTests(__DIR__ . '/client-side-encryption/*.json');
}

/** @dataProvider provideCollectionManagementTests */
/**
* @dataProvider provideCollectionManagementTests
* @group serverless
*/
public function testCollectionManagement(UnifiedTestCase $test): void
{
self::$runner->run($test);
Expand All @@ -267,7 +273,10 @@ public function provideCollectionManagementTests()
return $this->provideTests(__DIR__ . '/collection-management/*.json');
}

/** @dataProvider provideCommandMonitoringTests */
/**
* @dataProvider provideCommandMonitoringTests
* @group serverless
*/
public function testCommandMonitoring(UnifiedTestCase $test): void
{
self::$runner->run($test);
Expand All @@ -278,7 +287,10 @@ public function provideCommandMonitoringTests()
return $this->provideTests(__DIR__ . '/command-monitoring/*.json');
}

/** @dataProvider provideCrudTests */
/**
* @dataProvider provideCrudTests
* @group serverless
*/
public function testCrud(UnifiedTestCase $test): void
{
self::$runner->run($test);
Expand All @@ -289,7 +301,10 @@ public function provideCrudTests()
return $this->provideTests(__DIR__ . '/crud/*.json');
}

/** @dataProvider provideGridFSTests */
/**
* @dataProvider provideGridFSTests
* @group serverless
*/
public function testGridFS(UnifiedTestCase $test): void
{
self::$runner->run($test);
Expand All @@ -300,7 +315,10 @@ public function provideGridFSTests()
return $this->provideTests(__DIR__ . '/gridfs/*.json');
}

/** @dataProvider provideLoadBalancers */
/**
* @dataProvider provideLoadBalancers
* @group serverless
*/
public function testLoadBalancers(UnifiedTestCase $test): void
{
self::$runner->run($test);
Expand All @@ -322,7 +340,10 @@ public function provideReadWriteConcernTests()
return $this->provideTests(__DIR__ . '/read-write-concern/*.json');
}

/** @dataProvider provideRetryableReadsTests */
/**
* @dataProvider provideRetryableReadsTests
* @group serverless
*/
public function testRetryableReads(UnifiedTestCase $test): void
{
self::$runner->run($test);
Expand All @@ -333,7 +354,10 @@ public function provideRetryableReadsTests()
return $this->provideTests(__DIR__ . '/retryable-reads/*.json');
}

/** @dataProvider provideRetryableWritesTests */
/**
* @dataProvider provideRetryableWritesTests
* @group serverless
*/
public function testRetryableWrites(UnifiedTestCase $test): void
{
self::$runner->run($test);
Expand All @@ -344,7 +368,10 @@ public function provideRetryableWritesTests()
return $this->provideTests(__DIR__ . '/retryable-writes/*.json');
}

/** @dataProvider provideRunCommandTests */
/**
* @dataProvider provideRunCommandTests
* @group serverless
*/
public function testRunCommand(UnifiedTestCase $test): void
{
self::$runner->run($test);
Expand All @@ -355,7 +382,10 @@ public function provideRunCommandTests()
return $this->provideTests(__DIR__ . '/run-command/*.json');
}

/** @dataProvider provideSessionsTests */
/**
* @dataProvider provideSessionsTests
* @group serverless
*/
public function testSessions(UnifiedTestCase $test): void
{
self::$runner->run($test);
Expand All @@ -366,7 +396,10 @@ public function provideSessionsTests()
return $this->provideTests(__DIR__ . '/sessions/*.json');
}

/** @dataProvider provideTransactionsTests */
/**
* @dataProvider provideTransactionsTests
* @group serverless
*/
public function testTransactions(UnifiedTestCase $test): void
{
self::$runner->run($test);
Expand All @@ -390,6 +423,7 @@ public function provideTransactionsConvenientApiTests()

/**
* @dataProvider provideVersionedApiTests
* @group serverless
* @group versioned-api
*/
public function testVersionedApi(UnifiedTestCase $test): void
Expand Down