Leverage PHP 8.0 string functions #1274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
commented
Apr 8, 2024
tools/connect.php
Outdated
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| function getHosts(string $uri): array | |||
| { | |||
| if (strpos($uri, '://') === false) { | |||
| if (!str_contains($uri, '://')) { | |||
There was a problem hiding this comment.
This files doesn't include composer autoload. I've reverted this change.
jmikola
approved these changes
Apr 9, 2024
alcaeus
added a commit
that referenced
this pull request
May 21, 2024
* v1.19: DOCSP-37027: Fix build errors (#1289) PHPLIB-1415 Add tests for PHP 8.4 (#1287) PHPLIB-1163 Create tutorial for using MongoDB with Bref (#1273) Relax branch-alias on dev-master to avoid update on each release (#1277) PHPLIB-1424: Fix potentially racy w:0 unified tests (#1276) Leverage PHP 8.0 string functions (#1274) Master is now 1.19-dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use symfony/php80-polyfill that provides
str_starts_with,str_ends_withandstr_contains.