Skip to content

DOCSP-37027: Fix 1.16 build errors #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 9, 2024

Conversation

norareidy
Copy link
Contributor

@norareidy norareidy commented May 7, 2024

Copy link
Contributor

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@norareidy norareidy requested a review from jmikola May 7, 2024 20:04
@jmikola jmikola enabled auto-merge (squash) May 7, 2024 20:15
@jmikola jmikola disabled auto-merge May 7, 2024 20:21
@jmikola jmikola enabled auto-merge (squash) May 7, 2024 20:24
@jmikola
Copy link
Member

jmikola commented May 7, 2024

@alcaeus: the configured rulesets are preventing this from being merged into v1.16, and manually merging is also blocked. Please take a look when you get a chance.

Ideally, we should disable the "Build Docs" CI workflow on v1.16, as it cannot be completed. The additional workflows for Evergreen, Psalm, and phpcs are likely also irrelevant for docs PRs.

@jmikola jmikola disabled auto-merge May 9, 2024 17:27
@jmikola jmikola merged commit 3ced650 into mongodb:v1.16 May 9, 2024
1 of 2 checks passed
This was referenced May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants