Fix build #1291
Merged
Fix build #1291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
approved these changes
May 8, 2024
There was a problem hiding this comment.
Looking at mongodb/docs-php-library@f676202, I think the Snooty migration was applied to v1.16.
The v1.17 branch still includes 4d21326, which was meant to allow running Giza through ubuntu-20.04. Correct me if I'm wrong, but that's probably obsolete as well and we should remove docs.yml from all branches above v1.16 when merging this up.
Yes, my plan was to merge this up manually until the merge-up action picks it up. |
alcaeus
added a commit
to alcaeus/mongo-php-library
that referenced
this pull request
May 8, 2024
* v1.16: Fix build (mongodb#1291)
This was referenced May 8, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes some changes to the build system to ensure pull requests to older branches can be merged.