Skip to content

PHPLIB-1459: Retryable read/write prose tests for mongos selection #1333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented May 30, 2024

@jmikola jmikola force-pushed the phplib-1459 branch 4 times, most recently from 7ed8dc5 to 1f9c29c Compare May 30, 2024 18:19
jmikola added 2 commits May 30, 2024 20:40
This also moves the existing, third prose test into its own file.
@jmikola
Copy link
Member Author

jmikola commented May 31, 2024

Note: the command-monitoring/unacknowledgedBulkWrite failures are being tracked by PHPLIB-1461.

@jmikola jmikola marked this pull request as ready for review May 31, 2024 15:44
@jmikola jmikola requested a review from a team as a code owner May 31, 2024 15:44
@jmikola jmikola requested a review from alcaeus May 31, 2024 15:44
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Do you want to investigate the failing test since it blocks merges?

@jmikola jmikola merged commit a445660 into mongodb:master Jun 4, 2024
24 of 27 checks passed
@jmikola jmikola deleted the phplib-1459 branch June 4, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants