Skip to content

Use checkout and tag actions from drivers-github-tools #1344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Jun 13, 2024

This PR makes use of the secure-checkout and tag-version actions from drivers-github-tools to reduce the amount of logic in our release workflow.

@alcaeus alcaeus requested a review from jmikola June 13, 2024 11:13
@alcaeus alcaeus requested a review from a team as a code owner June 13, 2024 11:13
run: git push

- name: "Push release tag"
run: git push origin ${{ inputs.version }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume these two steps are handled entirely by the git push origin --tags line in tag-version/action.yml.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is correct

run: echo "GH_TOKEN=${{ steps.app-token.outputs.token }}" >> "$GITHUB_ENV"
shell: bash

- uses: actions/checkout@v4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted that this lines up with secure-checkout/action.yml.

@alcaeus alcaeus merged commit afe425b into mongodb:v1.19 Jun 13, 2024
27 checks passed
@alcaeus alcaeus deleted the use-common-release-actions branch June 13, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants