Skip to content

PHPLIB-1485: Drop support for MongoDB 3.6 #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Jul 16, 2024

PHPLIB-1485

With the extension dropping support for MongoDB 3.6 by bumping its minWireVersion (see mongodb/mongo-php-driver#1610), this PR removes MongoDB 3.6 from the test matrix and removes wire version checks related to MongoDB 3.6 as we know we'll never be connected to a 3.6 server.

@alcaeus alcaeus self-assigned this Jul 16, 2024
@alcaeus alcaeus requested a review from a team as a code owner July 16, 2024 07:17
@alcaeus alcaeus requested a review from GromNaN July 16, 2024 07:17
@alcaeus alcaeus force-pushed the phplib-1485-remove-mongodb-3.6 branch from 59a5c6e to 0e6f721 Compare July 16, 2024 07:49
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the behavior of the driver if someone tries to use it with MongoDB 3.4?

Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You only remove exceptions and let the connection error happen.

@alcaeus
Copy link
Member Author

alcaeus commented Jul 16, 2024

What is the behavior of the driver if someone tries to use it with MongoDB 3.4?

Note that 3.4 has been dropped a while ago, this PR drops support for 3.6. libmongoc will throw an error about the wire version not being supported:

Server at reports wire version , but this version of libmongoc requires at least 7 (MongoDB 4.0)

@alcaeus alcaeus merged commit de3aaf8 into mongodb:master Jul 16, 2024
36 checks passed
@alcaeus alcaeus deleted the phplib-1485-remove-mongodb-3.6 branch July 16, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants