PHPLIB-53: Create mapReduce command helper #392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
reviewed
Aug 9, 2017
src/Operation/MapReduce.php
Outdated
| return new TypeMapArrayIterator($result->results, $this->typeMap); | ||
| } | ||
|
|
||
| return new ArrayIterator($reesult->results); |
src/Operation/MapReduce.php
Outdated
| : new Find($result->result->db, $result->result->collection, $options); | ||
|
|
||
| return function() use ($find, $server) { | ||
| return $find->execute($server); |
There was a problem hiding this comment.
Nice idea for returning results in case an output collection was used. I might have to remember this for ODM as it would be useful when using an $out stage in aggregation builder.
jmikola
force-pushed
the
phplib-53
branch
2 times, most recently
from
12c3382 to
a7237b1
Compare
jmikola
changed the title
jmikola
force-pushed
the
phplib-53
branch
2 times, most recently
from
cf1ff11 to
5746cd5
Compare
jmikola
added a commit
that referenced
this pull request
Aug 17, 2017
|
Build failures were due to MongoDB 2.4 not installing on Travis. We'll address that in PHPLIB-279. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPLIB-53
/cc @alcaeus