-
Notifications
You must be signed in to change notification settings - Fork 266
PHPLIB-284 Highlight API changes in documentation #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're just missing .. versionadded:: 1.2
for MongoDBCollection-mapReduce.txt
.
.. versionadded:: 1.2 | ||
interface: phpmethod | ||
operation: ~ | ||
optional: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't realize this was in apiargs-common-option.yaml
after the previous PR. Good idea moving it back to find-option.yaml
.
@@ -2,6 +2,8 @@ | |||
MongoDB\\Collection::mapReduce() | |||
================================= | |||
|
|||
.. versionadded:: 1.2 | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added .. versionadded:: 1.2
for MongoDBCollection-mapReduce.txt here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My mistake. I scrolled right past this.
@@ -2,6 +2,8 @@ | |||
MongoDB\\Collection::mapReduce() | |||
================================= | |||
|
|||
.. versionadded:: 1.2 | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My mistake. I scrolled right past this.
https://jira.mongodb.org/browse/PHPLIB-284