Skip to content

PHPLIB-284 Highlight API changes in documentation #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2017

Conversation

kvwalker
Copy link
Contributor

@kvwalker kvwalker requested a review from jmikola October 25, 2017 18:45
Copy link
Member

@jmikola jmikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're just missing .. versionadded:: 1.2 for MongoDBCollection-mapReduce.txt.

.. versionadded:: 1.2
interface: phpmethod
operation: ~
optional: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize this was in apiargs-common-option.yaml after the previous PR. Good idea moving it back to find-option.yaml.

@@ -2,6 +2,8 @@
MongoDB\\Collection::mapReduce()
=================================

.. versionadded:: 1.2

Copy link
Contributor Author

@kvwalker kvwalker Oct 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added .. versionadded:: 1.2 for MongoDBCollection-mapReduce.txt here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake. I scrolled right past this.

@@ -2,6 +2,8 @@
MongoDB\\Collection::mapReduce()
=================================

.. versionadded:: 1.2

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake. I scrolled right past this.

@kvwalker kvwalker merged commit f96124f into mongodb:master Oct 25, 2017
@kvwalker kvwalker deleted the PHPLIB-284 branch October 25, 2017 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants