Skip to content

PHPLIB-297 Support maxTimeMS option for DropIndexes operation #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 15, 2017
Merged

PHPLIB-297 Support maxTimeMS option for DropIndexes operation #434

merged 2 commits into from
Nov 15, 2017

Conversation

kvwalker
Copy link
Contributor

@kvwalker kvwalker requested a review from jmikola November 14, 2017 17:07
jmikola
jmikola reviewed Nov 15, 2017
View reviewed changes
Copy link
Member

@jmikola jmikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please document maxTimeMS in the PHP doc block for the DropIndexes class. LGTM otherwise.

@kvwalker kvwalker merged commit 3e83aa7 into mongodb:master Nov 15, 2017
@kvwalker kvwalker deleted the PHPLIB-297 branch November 15, 2017 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmikola jmikola jmikola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kvwalker @jmikola