Add missing version info for 1.3.0 release #486
Conversation
| .. versionadded:: 1.3 | ||
|
|
||
| .. default-domain:: mongodb |
There was a problem hiding this comment.
This rendered fine before. Just re-ordering it for consistency with other RST files.
| MongoDB\\Collection::watch() | ||
| ================================ | ||
| ============================ |
There was a problem hiding this comment.
I didn't notice build warnings for the previous header lines (not sure if strict warnings are being suppressed), but it is something RST can sometimes complain about so this was a quick fix.
| @@ -5,6 +5,8 @@ source: | |||
| source: | |||
There was a problem hiding this comment.
Should maxTimeMS also show versionadded:: 1.3 here and in dropIndexes-option??
There was a problem hiding this comment.
Ah, I missed 3e83aa7. Thanks for catching that!
| @@ -70,6 +70,8 @@ optional: true | |||
| source: | |||
| file: apiargs-common-option.yaml | |||
| ref: session | |||
| post: | | |||
| .. versionadded:: 1.3 | |||
There was a problem hiding this comment.
Do you need to specify this here even though every option here was added in version 1.3 since Watch is new?
There was a problem hiding this comment.
Definitely not. This was likely the result of an over aggressive search/replace.
jmikola
force-pushed
the
docs-versionadded
branch
from
097bfdb to
41a6fb1
Compare
Noting version info on a per-method basis keeps this flexible if another method end up using the option in some later version.
This also fixes RST formatting for header lengths.
jmikola
force-pushed
the
docs-versionadded
branch
from
41a6fb1 to
9dc7918
Compare
I took a look through docs changes in the diff between
v1.2andmasterand I believe this is everything.Tested with a local docs build.