Skip to content

removed collectionName attribute in GridFSbucket construct signature #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

removed collectionName attribute in GridFSbucket construct signature #509

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 7, 2018

I saw on the mongodb docs that this was false, you can verify in the code.

@jmikola
Copy link
Member

jmikola commented Mar 7, 2018

Indeed, it looks like bad copypasta from the Collection documentation. The constructor has never had a $collectionName argument: https://github.com/mongodb/mongo-php-library/blob/1.1.0/src/GridFS/Bucket.php#L68

Thanks for the correction. I'll manually merge this to ensure it makes its way through all versions of the documentation.

@jmikola jmikola changed the base branch from master to v1.1 March 7, 2018 19:27
@jmikola jmikola changed the base branch from v1.1 to master March 7, 2018 19:27
jmikola added a commit that referenced this pull request Mar 7, 2018
@jmikola jmikola closed this Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant