Skip to content

PHPLIB-445: Leave key as-is if ChangeStream::next() fails to extract resume token #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2019

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented Jun 19, 2019

https://jira.mongodb.org/browse/PHPLIB-445

Note: this will conflict with #621, so it'd be preferable to resolve that first and then rebase this after merging up to master.

@jmikola
Copy link
Member Author

jmikola commented Jun 21, 2019

Rebased after merging #621 into v1.4 and up to master.

Copy link
Contributor

@kvwalker kvwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@jmikola jmikola merged commit d13ab85 into mongodb:master Jun 21, 2019
jmikola added a commit that referenced this pull request Jun 21, 2019
@jmikola jmikola deleted the phplib-445 branch June 21, 2019 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants