Refactor command logging for spec tests and fix docs #645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
approved these changes
Jul 26, 2019
There was a problem hiding this comment.
LGTM, but can you add "PHPLIB-438:" to the $merge-related commit so it gets cross-referenced with https://jira.mongodb.org/browse/PHPLIB-438?
alcaeus
added a commit
to alcaeus/mongo-php-library
that referenced
this pull request
Jul 29, 2019
Merged from mongodb#645. * Don't collect unexpected extra commands in spec tests: as discussed in mongodb#642 (comment), it makes more sense to not collect commands that we're not going to be asserting against instead of dropping them later. * While the docs for the aggregation helpers in `MongoDB\Database` and `MongoDB\Collection` have been updated with respect to read concerns and write stages, the documentation in the `MongoDB\Operation\Aggregate` wasn't. This is done in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MongoDB\DatabaseandMongoDB\Collectionhave been updated with respect to read concerns and write stages, the documentation in theMongoDB\Operation\Aggregatewasn't. This is done in this PR.