Use named datasets in spec tests #650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
force-pushed
the
phpunit-named-datasets
branch
from
681cc5f to
f680868
Compare
This fixes issues in tools like PhpStorm that are not able to show test progress when the test name changes.
alcaeus
force-pushed
the
phpunit-named-datasets
branch
from
f680868 to
0ab1782
Compare
jmikola
reviewed
Jul 29, 2019
There was a problem hiding this comment.
Can you post a quick example of CLI output when one of these tests fails? I wasn't aware that data providers could name each entry via the array/iterator key, which is why I had been using setName(). I'd just like to make sure we can still easily identify the JSON test by name in the event of a failure.
|
Tested this myself:
That looks totally fine. PHPUnit's manual no longer displays docs for 5.x, but I assume this functionality is nothing new. LGTM! |
jmikola
approved these changes
Jul 30, 2019
Not sure when it was added, but it was before PHPUnit 4 IIRC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issues in tools like PhpStorm that are not able to show test progress when the test name changes.